Skip to content

Conversation

@tshepang
Copy link
Member

@tshepang tshepang commented Oct 20, 2025

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jieyouxu
Copy link
Member

Just thinking if there is way to optimize the review time on these tiny fixes you're pushing.

Is it possible to batch some of these smaller fixes? Otherwise the review time here would be blocked on someone noticing a new PR.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take this, but I think we really should batch these smaller wording fixes going forward.

@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Oct 26, 2025
@jieyouxu jieyouxu enabled auto-merge October 26, 2025 11:28
@jieyouxu jieyouxu merged commit 96fed93 into master Oct 26, 2025
1 check passed
@jieyouxu jieyouxu deleted the tshepang-patch-2 branch October 26, 2025 11:29
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2025
@tshepang
Copy link
Member Author

I fix these when I notice a problem when reading some small portion of the whole text, so batching them is basically asking me to read more than I need for the information am looking for. If not, how long should I keep an improvement in private?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants